#3 Possible memory leak because of Ticker

marek5050 commented 7 years ago

PR for Issue #3
Added the Ticker Stop()

Go test results:

~/goexpect$ go test
E0821 14:02:26.983666   11558 expect_test.go:135] Accept failed: accept tcp [::]:32844: use of closed network connection
E0821 14:02:27.002522   11558 expect_test.go:203] PTY cols/rows: 240/22 want: 120/40
E0821 14:02:27.002759   11558 expect_test.go:135] Accept failed: accept tcp [::]:41063: use of closed network connection
PASS
ok      _/home/marek/goexpect   11.224s

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

marek5050 commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

google / goexpect

#3 Possible memory leak because of Ticker #4