Reduce blocking the calling thread when calculating default user-agent string

google / google-api-objectivec-client-for-rest

Google APIs Client Library for Objective-C for REST

Apache License 2.0

775 stars 308 forks source link

Reduce blocking the calling thread when calculating default user-agent string #616

Closed bhamiltoncx closed 9 months ago

bhamiltoncx commented 9 months ago

Fixes #615.

thomasvl commented 9 months ago

Can you also do a sync, it looks like there's a conflict on GTLRService.m.

bhamiltoncx commented 9 months ago

Can you also do a sync, it looks like there's a conflict on GTLRService.m.

Whoops, fixed.

thomasvl commented 9 months ago

Leaning in the directions of #623 because it seems to better put the work at first query time instead of at Service creation, so that seems a little better.

bhamiltoncx commented 9 months ago

Cool, I'm happier with #623 as well. Closing this PR in favor of that one.