google / google-authenticator-android

Open source fork of the Google Authenticator Android app
https://play.google.com/store/apps/details?id=com.google.android.apps.authenticator2
Apache License 2.0
1.6k stars 471 forks source link

Show issuer #52

Closed azhao12345 closed 8 years ago

azhao12345 commented 8 years ago

read and show the issuer

I'm just going to leave this here in case anyone wants it, because I'm too lazy to do all the tests.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


azhao12345 commented 8 years ago

oh hell no if you're gonna be like that you can't have it

ocdtrekkie commented 8 years ago

I'm not super fond of El Goog's general behavior but FWIW a CLA is pretty standard for an open source project.

capi commented 8 years ago

The CLA is a very basic one and ensures that this version remains open-source and that they still have everything they need to use it in their products and also could change license for future releases, without a sign-off by every single contributor. It's pretty basic for any open-source project, or otherwise it tends to get a lot of problems later on.