google / google-authenticator-libpam

Apache License 2.0
1.77k stars 281 forks source link

Enable a grace period for 2fa #125

Closed wom-bat closed 5 years ago

wom-bat commented 5 years ago

Track the last ten IP addresses that successfully logged in, and the times at which that happened. A new 'grace_period' parameter takes a number of seconds: if a login attempt succeeded within the last grace_period seconds, then allow access without asking for another verification code.

This addresses issue #40

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

wom-bat commented 5 years ago

I'm trying to find out if my company has a CLA with Google.

wom-bat commented 5 years ago

The CLA is now with our legal department. We don't have one yet.

wom-bat commented 5 years ago

The CLA has been signed.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ThomasHabets commented 5 years ago

First time I've used the github code suggestion thing. Hopefully it's a good UI on your side too.

wom-bat commented 5 years ago

First time I've used the github code suggestion thing. Hopefully it's a good UI on your side too.

I don't see any comments? You have to `commit' the review up in the top rh corner to make them visible to me. I've added a couple of obvious things that have to be changed so you can see what it looks like!

ThomasHabets commented 5 years ago

@wom-bat thanks. Visible now?

wom-bat commented 5 years ago

To get a clean patch, I'll close this PR and generate another with one patch that covers all your comments.

wom-bat commented 5 years ago

New pull request with clean history generated.