search

google / google-authenticator-libpam

Apache License 2.0
1.77k stars 281 forks source link

Enable a grace period for two-factor authentication. #127

Closed wom-bat closed 5 years ago

wom-bat commented 5 years ago

Track the last ten IP addresses used to log in, and the time at which a succesful login attempt occurred. Add a new 'grace_period' parameter to the PAM module. If a new login attempt is made within grace_period seconds, allow it without requiring another authentication token.

This addresses github issue #40 and is a version that cleans up all the comments in PR #125

Signed-off-by: Peter Chubb peter.chubb@data61.csiro.au

wom-bat commented 5 years ago

Hi, Our legal department wants the name, title, address, email, and phone number of the Google person who administers the CLAs, for their records. Can you please put me in touch with the appropriate person?

ThomasHabets commented 5 years ago

I'm looking into it.

willnorris commented 5 years ago

It's actually a team of people, but you can reach them at opensource@google.com if there are any questions.

ThomasHabets commented 5 years ago

I intend to merge this. I'm just swamped at the moment.

wom-bat commented 5 years ago

I intend to merge this. I'm just swamped at the moment. Fine, take what time you need.

ThomasHabets commented 5 years ago

I want to stare at the C string handling some more, in addition to the comments left.

I'll squash everything down to one commit, so don't worry about a clean history.

ThomasHabets commented 5 years ago

If my comments feel like nitpicking and you prefer to just be done with it I can merge this pull request and do fixups myself.

wom-bat commented 5 years ago

Unless there are more substantive changes, go ahead and merge and do whatever minor fixups are necessary. I think we've converged now,

ThomasHabets commented 5 years ago

Thanks!