Open krzole opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.
. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
Oooh, very cool. Things this needs before being mergable:
I won't have time look at the code today. but looks very promising.
@googlebot I fixed it.
@ThomasHabets: pull request is updated with the suggested changes
@ThomasHabets Hello Thomas, how shall we continue with this pull request?
@krzole I've not had time to look at this more yet.
Although now I'm wondering if it actually belongs in the same module. How is this better than having a separate PAM module that does authy? The fallback logic is normally done in the PAM config.
This pull request adds push authentication using Authy (https://authy.com/). If Authy authentication fails, continue with the classic Google OTP. See README.authy.md how to install and use.