search

google / google-authenticator-libpam

Apache License 2.0
1.76k stars 281 forks source link

Does not support 8 digits codes #20

Open ThomasHabets opened 7 years ago

ThomasHabets commented 7 years ago

From @ThomasHabets on October 10, 2014 8:7

Original issue 327 created by charly.rohart on 2013-09-26T14:25:45.000Z:

Can you add support for 8 Digits OTP codes?

6 digits is the most common use Ok - but 8 is frequently preferred when strong security is required. The OATH internal code is the same in both - just a minor adjustment is required to support 8 digits. Is is planned in a near future in the roadmap?

Copied from original issue: google/google-authenticator#326

ThomasHabets commented 7 years ago

Comment #1 originally posted by Roman2025 on 2014-04-10T21:35:11.000Z:

Yes, please add 8 digit code support. Those of us wanting to use Google Authenticator in more secure/enterprise environments are limited due to this.

Thanks!

ThomasHabets commented 7 years ago

From @james-d-elliott on September 4, 2016 5:31

I agree. An example service that uses 8 digits is Battle.net, be easier to have one app.

ThomasHabets commented 6 years ago

The RFCs allow for it, so pull requests welcome. :-)

anarcat commented 3 years ago

this would be required for yubikey compatibility (#186) as well, so :+1: from me. :)

scratch that:: yubikeys actually already work with this module, so nevermind. :)

timwoj commented 2 years ago

Any chance we could get that commit above merged and a new release done supporting 8 digits? That'd be awesome.

ThomasHabets commented 2 years ago

What commit?

timwoj commented 2 years ago

The one from https://github.com/mgorny/google-authenticator-libpam-hardened/commit/8a5f0046191a7d40846508888596d580ad22698a

ThomasHabets commented 2 years ago

Ah. I've not gotten a pull request.

I just tried merging it, but it requires some work to apply.

I'll accept pull requests backporting it.

ruedigerkupper commented 2 years ago

Hm, it appears to be working with 8 digits here (Ubuntu 20.04.3 LTS with GNOME/gdm).

Dockter commented 1 year ago

Any chance this is going to get built out?

dv-petrov commented 1 year ago

Any news?

ThomasHabets commented 1 year ago

I'm still open to merging a well written PR.

davama commented 2 months ago

I'm still open to merging a well written PR.

@mgorny

thank you for your commit. Wanted to see if Thomas’ request was possible with your commit.

Best