search

google / google-authenticator-libpam

Apache License 2.0
1.8k stars 286 forks source link

Question: google-authenticator PAM module is not returning valid error codes #258

Open raviteja-b opened 3 weeks ago

raviteja-b commented 3 weeks ago

pam_google_authenticator identifies different error cases but returns generic PAM_AUTH_ERR

when totp token is not passed then I noticed this trace and I see PAM_AUTH_ERR pam_google_authenticator: Did not receive verification code from user

when invalid totp token is passed, I noticed this trace which says invalid token but still PAM_AUTH_ERR error returned. pam_google_authenticator: Invalid verification code for testmfaadmin

pam_authenticate() should return PAM_CRED_INSUFFICIENT, If there is no token is provided

ThomasHabets commented 3 weeks ago

That sounds correct. I'll accept well written PRs.