search

google / google-authenticator

Open source version of Google Authenticator (except the Android app)
Apache License 2.0
5.17k stars 966 forks source link

Use "!=" to Compare Integer #675

Closed QiAnXinCodeSafe closed 4 years ago

QiAnXinCodeSafe commented 5 years ago

The counter type is "Integer",it could be less than -128 or more than 127.Therefore it should use "equals" to compare

https://github.com/google/google-authenticator/blob/0e8cc0a3bcada1f8f35191bd0f9f95403da65ffc/mobile/blackberry/src/com/google/authenticator/blackberry/AuthenticatorScreen.java#L157

ThomasHabets commented 5 years ago

Thanks.

I doubt this'll be fixed, since who has a Blackberry in 2019?