search

google / google-authenticator

Open source version of Google Authenticator (except the Android app)
Apache License 2.0
5.17k stars 966 forks source link

App crash when scanning malformed qr code #677

Closed ComanderKai77 closed 4 years ago

ComanderKai77 commented 4 years ago

The app is crashing when an incorrect qr code is scanned.

What steps will reproduce the problem?

  1. Open the app and go to scan barcode
  2. Scan the qr code with the content

otpauth://totp/%2?secret=s

or scan directly this qr code https://pasteboard.co/Iordizm.png

  1. The app will crash

Version of the app 5.00

Android version 8.0.0 on a Honor 7X

ThomasHabets commented 4 years ago

Neat!

MrPickles commented 4 years ago

Fix has been made internally (though it won't be public until the next Authenticator release). Open source fix is at google/google-authenticator-android#101.

ThomasHabets commented 4 years ago

Oh yeah, I didn't catch that this bug report is on the wrong (non-android repo). Do you want to submit this, or waiting for me to push that button?

ThomasHabets commented 4 years ago

Or do you plan to have everything overwritten with the next version dump?

MrPickles commented 4 years ago

Oh I was just waiting for you to push the button. Just resolved that PR.