search

google / google-java-format

Reformats Java source code to comply with Google Java Style.
Other
5.58k stars 855 forks source link

Misleading message for --dry-run with --replace #1094

Open norrisgc opened 6 months ago

norrisgc commented 6 months ago

If you specify both --dry-run (or -n) and --replace (or -replace, -r or -i) you get a message stating "cannot use --dry-run and --in-place at the same time".

The problem is that there is no --in-place option. inPlace is however the internal variable name used for --replace. There's two possible fixes:

  1. Change the message. This could affect anything which tries to use the message in some kind of script.
  2. Add the --in-place option at line 68 in CommandLineOptionsParser.java and related help text. This should not affect anything else.