search

google / googleapis.dart

Repository for building the googleapis packages
https://pub.dev/packages/googleapis
BSD 3-Clause "New" or "Revised" License
393 stars 119 forks source link

Breaking change to AutoRefreshingClient in googleapis_auth-v1.5.0 #622

Closed SandPod closed 5 months ago

SandPod commented 5 months ago

This PR, https://github.com/google/googleapis.dart/pull/597, introduces a breaking change to the AutoRefreshingClients constructor.

The constructor was changed in a non-backward compatible way when the mandatory authEndpoints parameter was added, source: https://github.com/google/googleapis.dart/blame/0c28d453fda3097e7b0d68fe395afe4a25ef33cd/googleapis_auth/lib/src/auth_http_utils.dart#L99.

I'm a maintainer of the Serverpod framework, and our users are running into issues when running pub update since the release was not tagged as a major version.

kevmoo commented 5 months ago

Ah! That's less than ideal.

It seems we've already released 3 versions with this fix:

I try SUPER hard to avoid this types of mistakes, but I'm not sure what I can do now about it.

Suggestions?

SandPod commented 5 months ago

I can relate to this, and it's a simple mistake to make.

Honestly, I'm not sure there is any action to take here without breaking things again. The semantic versioning spec encourages you to use your best judgement, source, and in this case I think it would be best to take the loss.

I would suggest closing this issue with a won't fix so that the decision is tracked, and then recommend everyone to bump their minimum version to 1.5.0.

kevmoo commented 5 months ago

Agree! Sadly, nothing to do. Folks should update their dependency to ^1.5.0. Sorry!