Is "#if GTEST_HAS_TYPED_TEST_P" (as seen in sample code) still necessary?

google / googletest

GoogleTest - Google Testing and Mocking Framework

https://google.github.io/googletest/

BSD 3-Clause "New" or "Revised" License

34.8k stars 10.15k forks source link

Is "#if GTEST_HAS_TYPED_TEST_P" (as seen in sample code) still necessary? #3234

Open nathanielmanistaatgoogle opened 3 years ago

nathanielmanistaatgoogle commented 3 years ago

I was surprised to see #if GTEST_HAS_TYPED_TEST_P in googletest/samples/sample6_unittest.cc, and turning on the blame layer shows that it's more than a decade old. Is it just leftover cruft that can be cleaned up? Alternatively, is it still necessary and required?

derekmauro commented 3 years ago

It looks like it could be cleaned up, at least in the sample. I don't think any compiler supported today lacks this.