search

google / googletest

GoogleTest - Google Testing and Mocking Framework
https://google.github.io/googletest/
BSD 3-Clause "New" or "Revised" License
33.78k stars 10k forks source link

Cleanup include paths #4408

Closed tmiguelf closed 8 months ago

tmiguelf commented 8 months ago

Used local path instead of additional include directories to find needed gtest-internal-inl.h (improves compatibility with other build methods)

derekmauro commented 8 months ago

The current #include structure works with all of our supported build systems. Supporting other systems introduces a maintenance burden.

tmiguelf commented 8 months ago

@derekmauro Please reconsider.

  1. There is only 1 header file in the entire project that requires /src to be included in the additional includes directory. This is the first time ever that this has happened.
  2. It goes against best practices to use additional include directories for files that are side by side, and even more so if the header file is private.