search

google / googletest

GoogleTest - Google Testing and Mocking Framework
https://google.github.io/googletest/
BSD 3-Clause "New" or "Revised" License
34.52k stars 10.09k forks source link

Only apply -lregex for qnx710 and newer #4444

Closed michaeldleslie closed 8 months ago

michaeldleslie commented 8 months ago

In QNX versions prior to 7.1, the regex functionality was located in libc.a and no extra linker flag was required. In QNX 7.1 and newer, we do need to link against the new libregex, which is what the current approach does always, breaking builds against older QNX versions.

Add check of CMAKE_SYSTEM_VERSION to handle this. QNX 7.0 is admittedly long in the tooth but it would be nice to keep this in good shape until it's commercially EOL'd in 2027.

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.