google / googletest

GoogleTest - Google Testing and Mocking Framework
https://google.github.io/googletest/
BSD 3-Clause "New" or "Revised" License
33.68k stars 9.98k forks source link

Minor fixes to gtest_build_tests=ON #4518

Open puetzk opened 2 months ago

puetzk commented 2 months ago

Fix some failures identified in gtest_build_tests=ON when trying to build googletest with winegcc for a winelib application (i.e. when using a POSIX libc/libstdc++, but with some win32 API available).

Context: I have additional patches in the branch https://github.com/puetzk/googletest/commits/wine/, but I don't think their maturity (or popularity) makes sense to upstream at this time. But these two commits are stand-alone fixes that seem generally applicable, so I've cherry-picked them.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.