search

google / googletest

GoogleTest - Google Testing and Mocking Framework
https://google.github.io/googletest/
BSD 3-Clause "New" or "Revised" License
33.68k stars 9.98k forks source link

ParseInt32: Check for str not being a null pointer before parsing string as an int32 #4538

Closed tobbi closed 1 month ago

tobbi commented 1 month ago

Now, this is not too big of an issue since all the functions calling this already do this, but better be safe than sorry.

derekmauro commented 1 month ago

Thanks, but we don't need this. This is an internal function with 4 callers.

tobbi commented 1 month ago

@derekmauro Mind reviewing any of my other PRs just so I can have the good feeling of having contributed something to Google code?