search

google / googletest

GoogleTest - Google Testing and Mocking Framework
https://google.github.io/googletest/
BSD 3-Clause "New" or "Revised" License
33.68k stars 9.98k forks source link

Fix old versions of CMake erroneously reporting Intel LLVM as Clang #4541

Closed tobbi closed 1 month ago

tobbi commented 1 month ago

This adds a check for the specific edge case of CMAKE versions less than 3.20 reporting Intel LLVM compilers as Clang.

I've verified this using the steps described in #4315 and it works just fine.

Fixes #4315

derekmauro commented 1 month ago

Carrying a workaround for an unsupported platform is a maintenance burden. CMake itself doesn't even support this platform until 3.20. Here we are proposing working around an unsupported platform in a tool that doesn't support it either. Anyone serious about using CMake with IntelLLVM should just grab a copy of CMake that supports this.

tobbi commented 1 month ago

Maybe it would help closing the original issue as well? It really is discouraging when you fix an issue that you ("Google") supposedly need help with only to be met with this message.

derekmauro commented 1 month ago

Maybe it would help closing the original issue as well? It really is discouraging when you fix an issue that you ("Google") supposedly need help with only to be met with this message.

Sorry about that. I apologize for asking for help, but please realize that it wasn't until I saw your patch that I realized that it would have been best to just suggest upgrading CMake.