google / gopacket

Provides packet processing capabilities for Go
BSD 3-Clause "New" or "Revised" License
6.35k stars 1.13k forks source link

decodeTLSRecords should not replace the BaseLayer contents #1177

Open gchux opened 5 months ago

gchux commented 5 months ago

Indeed this line should be removed as it is impossible to access the full bytes from Layer to implement TLS Handshake decoding ( which is not implemented ).

https://github.com/google/gopacket/blob/a9779d139771f6a06fc983b18e0efd23ca30222f/layers/tls.go#L138