Closed zouguangxian closed 4 years ago
Hey Zou.
Exciting stuff!.
@googlebot I signed it!
Thx. a lot for that addition! .
Hey Zou. Ran into some problems with the Circle CI tests.
Have to revert until we have those under control.
===
go test -v ./...
term/termios.go:302:34: undefined: syscall.TIOCPTYGNAME term/termios.go:304:65: undefined: syscall.TIOCPTYGNAME term/termios.go:389:85: undefined: syscall.TIOCPTYUNLK term/termios.go:394:77: undefined: syscall.TIOCPTYGRANT
term/termios.go:302:34: undefined: syscall.TIOCPTYGNAME term/termios.go:304:65: undefined: syscall.TIOCPTYGNAME term/termios.go:389:85: undefined: syscall.TIOCPTYUNLK term/termios.go:394:77: undefined: syscall.TIOCPTYGRANT FAIL github.com/google/goterm/term [build failed]
Exited with code exit status 2
CircleCI received exit code 2
Hey zouguangxian@ are you sorting out the tests for this PR?
You could use Conditional Compiling to split the linux and MacOS tests. Eg. http://blog.ralch.com/tutorial/golang-conditional-compilation/
I'd love to have MacOS support for GoTerm , if you don't have the cycles I'll try to find some cycles to sort out the tests. With your permission ofcourse.
Hey @skalle, Yes, you can fully control the code, I'm glad you have the cycles to do fix it.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with
@googlebot I signed it!
and we'll verify it.What to do if you already signed the CLA
Individual signers
Corporate signers
ℹ️ Googlers: Go here for more info.