search

google / gousb

gousb provides low-level interface for accessing USB devices
Apache License 2.0
838 stars 124 forks source link

Redefine constants around control request types. #34

Closed zagrodzki closed 6 years ago

zagrodzki commented 6 years ago

This change provides a workaround for imperfect API of the control request. Addresses #33 .

zagrodzki commented 6 years ago

+@nkovacs

zagrodzki commented 6 years ago

oh, also for the record - the RequestType type was not used anywhere except for the constants and RequestType* values were not of RequestType type. So I think it's ok to remove old constants entirely, they're unlikely to be used by anyone.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 78.513% when pulling a5ee9a1c6b5f60f204d8165333d294a51884f6da on controlconst into d0366361a25268248b2e53405b91eaa0deadf761 on master.

stapelberg commented 6 years ago

the RequestType type was not used anywhere

I tried verifying whether this holds true using SourceGraph, but it wouldn’t show me cross-references for some reason.

zagrodzki commented 6 years ago

I get "Processing symbols is taking longer than expected. Try again in a while" from SourceGraph. Oh well.