google / graphicsfuzz

A testing framework for automatically finding and simplifying bugs in graphics shader compilers.
Apache License 2.0
562 stars 117 forks source link

cov: add function coverage option #1108

Closed karineek closed 3 years ago

karineek commented 3 years ago

I added a new option: --gcov_functions to generate instead of line coverage, the function coverage when using JSON format. I did testing to check that without the new flag, the tool still generates line coverage, and with the new flag, the tool generates function coverage.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

karineek commented 3 years ago

@googlebot I signed it!

afd commented 3 years ago

@karineek I think you need to fix some formatting errors, using the check_all.sh and fix_all.sh scripts under gfauto. Can you give that a try? See "## Presubmit checks and protobuf generation" in the README.