Tried fixing the issue #959 Transformation idea: vector access like .…

[KishkinJ10]

…x to [o] & also made some updates in the read me file , please take a look at these changes as i am a beginner , it will help me very much in contributions.

[google-cla[bot]]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[KishkinJ10]

Sorry sir , I am a beginner and I wanted to start my open source journey by making a contribution

On Fri, 26 Mar 2021, 7:18 pm Alastair Donaldson, @.***> wrote:

@.**** commented on this pull request.

This PR has major problems and does not compile.

In common/src/main/java/com/graphicsfuzz/common/util/IRandom.java https://github.com/google/graphicsfuzz/pull/1129#discussion_r602374320:

-/*

• • Copyright 2018 The GraphicsFuzz Project Authors
• *

Why have you deleted this file?

In CONTRIBUTING.md https://github.com/google/graphicsfuzz/pull/1129#discussion_r602374852:

@@ -1,6 +1,6 @@

How to Contribute

-We'd love to accept your patches and contributions to this project. There are +We'd love to accept your patches ,bug and issue fixes and contributions to this project. There are

This change has nothing to do with the issue you are addressing. (And also it is typographically incorrect.)

In generator/src/main/java/com/graphicsfuzz/generator/fuzzer/OpaqueExpressionGenerator.java https://github.com/google/graphicsfuzz/pull/1129#discussion_r602375945:

@@ -1076,6 +1077,33 @@ public Expr apply(Expr expr, BasicType type, boolean constContext, int depth,

}

• private class IdentityVectorComponent extends AbstractIdentityTransformation{
• private IdentityVectorComponent(){
• super(Arrays.asList(BasicType.BOOL), false);
• }
• @Override
• public Expr apply(Expr expr, BasicType type, boolean constContext, int depth,
• Fuzzer fuzzer){
• assert type == BasicType.BOOL;
• result

This doesn't look like it compiles.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/graphicsfuzz/pull/1129#pullrequestreview-622254539, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATKEH5ZWM63RHQNOFYTHNX3TFSQTTANCNFSM4Z3N7XKQ .