google / graphicsfuzz

A testing framework for automatically finding and simplifying bugs in graphics shader compilers.
Apache License 2.0
558 stars 117 forks source link

Generator can introduce name clashes with variable via introduction of built-ins #212

Open afd opened 5 years ago

afd commented 5 years ago

If you have code like:

void main() { int max; }

the generator might introduce calls to the built-in "max" function, leading to invalid GLSL according to glslangValidator.

This should be fixed by doing a scope check before introducing built-ins.

afd commented 5 years ago

Removing this from the release milestone. It is an edge-case issue.