search

google / ground-android

Ground mobile data collection app for Android
http://groundplatform.org
Apache License 2.0
243 stars 114 forks source link

[Select one - other] Deselecting "other" option doesn't hide/disable "Other" text #2399

Open gino-m opened 5 months ago

gino-m commented 5 months ago

When "other" option is disabled, either by clicking another radio box (select one) or by deselected the "other" checkbox (select many), the other text remains visible in the UI,

@rawbzz @vittorino What is the expected behavior here? @justinkimtang FYI

Screen_recording_20240322_160349.webm

rawbzz commented 5 months ago

@gino-m do you have a screenshot of what you're referring to?

gino-m commented 5 months ago

@gino-m do you have a screenshot of what you're referring to?

Sure! Just added to the description above.

rawbzz commented 5 months ago

@gino-m thank you! I feel like it makes sense to only have the other option text field to show up when someone selects other. That way if they choose option a or b the other text field just disappears cc: @vittorino for his thoughts

NudurupatiSurya commented 3 months ago

Hello @gino-m,

Can I work on this issue?

Thanks, Surya

gino-m commented 3 months ago

Yes, please! Can you also verify this is still occurring?

NudurupatiSurya commented 3 months ago

Hi @gino-m,

Thank you! I just verified that the issue is still occurring. Please find the attached screen recording for reference.

https://github.com/google/ground-android/assets/53263580/c0165c8b-5c35-4c06-b7f9-cafe2b84c4a4

To confirm, the expected functionality is that the text box should only be shown when the "Other" option is selected. If the user selects options A or B, the text box should hide. Is that correct, or should the text box be in a disabled state when the user selects options A or B?

Looking forward to your input to ensure I'm moving in the right direction.

Best, Surya

gino-m commented 3 months ago

Thank you for confirming.

To confirm, the expected functionality is that the text box should only be shown when the "Other" option is selected. If the user selects options A or B, the text box should hide.

Good question. I think the "Other" behavior should actually be as follows:

Please let me know if you have any other questions!

NudurupatiSurya commented 2 months ago

Thank you for clarifying! I will have a PR up by Wednesday.

NudurupatiSurya commented 2 months ago

Hello Gino,

Sorry for the delayed response. I checked the current implementation, and the behavior seems correct—entering text into the "Other" textbox selects the "Other" option, and the response is not sent if the "Other" option is not selected.

I observed that the keyboard stays up if we select the "Other" option and then select a different option. Should we make the keyboard hide in this case?

Looking forward to your direction 😊

Best, Surya

shobhitagarwal1612 commented 2 months ago

Focus from the "other" text should also be removed once any other option is selected.

NudurupatiSurya commented 2 months ago

Hello @gino-m & @shobhitagarwal1612,

Thank you for your guidance! I have just raised PR #2528 for this issue. Please review it and provide your feedback.

Thanks, Surya