google / ground-android

Ground mobile data collection app for Android
http://groundplatform.org
Apache License 2.0
234 stars 112 forks source link

[Draw area task] Location card obscures location lock button #2442

Closed gino-m closed 1 week ago

gino-m commented 4 months ago

Screenshot 2024-04-12 at 8 24 28 AM

Screenshot 2024-04-12 at 8 25 41 AM

@rawbzz Is looking at this UI element now, may want to wait for final designs before fixing.

gino-m commented 4 months ago

To consider in context of new popup card design

rawbzz commented 4 months ago
Screenshot 2024-04-19 at 1 30 26 PM
gino-m commented 4 months ago

I like it! @rawbzz Should we make the styling of the line more consistent with the blue dot styling (e.g., white?)

Also, Can you update the text of current location to show Lat Lng without Altitude, and with Accuracy being shown when location lock is enabled?

rawbzz commented 4 months ago

yes! how is accuracy measured? Also would i need to show lat lng if accuracy is shown? or just one or the other shows?

gino-m commented 4 months ago

For now we can just show meters (m). In the future we will probably want to add a setting for other units.

Lat/lng would always be shown, since it applies both to manual selection and auto/current location. Accuracy only applies when location lock is enabled.

rawbzz commented 4 months ago

Maybe something like this??

Screenshot 2024-04-19 at 3 59 28 PM Screenshot 2024-04-19 at 3 59 34 PM
gino-m commented 4 months ago

@rawbzz Looks great! One nit: Can the card w/accuracy be made to fit in two lines, perhaps by showing Accuracy right aligned?

rawbzz commented 1 week ago

ah yes! I realize the updated mock wasn't here, i have this one. Drop a pin - Collapsed