google / ground-android

Ground mobile data collection app for Android
http://groundplatform.org
Apache License 2.0
245 stars 119 forks source link

[Data collection] Clicking "x" in top left corner discards data without prompting user #2635

Open gino-m opened 3 months ago

gino-m commented 3 months ago

User should be prompted whether they want to lose/discard the data they've collected so far:

Screenshot_20240812_153956

@amegantz @rawbzz for input.

amegantz commented 3 months ago

image If you close this job, any data you’ve collected so far will be discarded. Are you sure you want to close this job?

gino-m commented 3 months ago

image If you close this job, any data you’ve collected so far will be discarded. Are you sure you want to close this job?

The term "job" is already taken - it refer the full set of tasks to be done for a set of LOIs. Taken literally, this text would make it seem as if data for other LOIs will also be lost. How can we disambiguate?

amegantz commented 2 months ago

To clarify, what does tapping the "X" do? Cancel the job or just this task?

gino-m commented 2 months ago

To clarify, what does tapping the "X" do? Cancel the job or just this task?

It stops the data collection flowm discarding data collected so for. You can't "cancel" as task, per se, but you can tap "Skip" to jump to the next if the task is optional.

amegantz commented 2 months ago

Is this more accurate? image Close task? If you close this task, any data you’ve collected for this task will be discarded. [Cancel] [Confirm]

gino-m commented 2 months ago

@amegantz The "x" stops the whole data collection flow; data from this and other tasks (i.e., the submission) is lost. Perhaps something along the lines of "Exit/quit/abort data collection?" ... "If you leave without submitting data collected so far will be lost"?

amegantz commented 2 months ago

image How about this?

gino-m commented 2 months ago

Lg! On nit: perhaps we should remove "any" so that they don't think this includes previous unsynced submissions?

amegantz commented 2 months ago

image

Stop collecting data? If you exit before submitting data, data you’ve collected so far will be discarded. [Cancel] [Confirm]

gino-m commented 2 months ago

"Data collected so far" might mean "since all time". What about: "If you stop now, unsubmitted data will be lost"?

amegantz commented 2 months ago

image Stop collecting data? If you exit, data you haven’t submitted yet will be discarded. [Cancel] [Confirm]