search

google / ground-android

Ground mobile data collection app for Android
http://groundplatform.org
Apache License 2.0
243 stars 114 forks source link

[UI] Dark theme currently not supported #620

Open gino-m opened 3 years ago

gino-m commented 3 years ago

Colors that don't look quite right

gino-m commented 6 months ago

@sufyanAbbasi Can we force light mode on for now, perhaps like this?

sufyanAbbasi commented 6 months ago

Unfortunately, the solution <item name="android:forceDarkAllowed">false</item> only works on Android >=29, but we are currently targeting 24, most likely for backwards compatibility reasons.

It is possible to make a v29/styles.xml which will presumably apply to those versions or higher, but it looks like the style rules can end up skewing if we're not careful.

gino-m commented 6 months ago

Unfortunately, the solution <item name="android:forceDarkAllowed">false</item> only works on Android >=29, but we are currently targeting 24, most likely for backwards compatibility reasons.

It is possible to make a v29/styles.xml which will presumably apply to those versions or higher, but it looks like the style rules can end up skewing if we're not careful.

Can setDefaultNightMode() be used here

sufyanAbbasi commented 6 months ago

I'll give it a shot!

sufyanAbbasi commented 6 months ago

It actually worked!

anandwana001 commented 3 weeks ago

@sufyanAbbasi What's the update on this Bug? Are we having dark mode or keeping in light theme only? Also, if we are having Dark Theme, can you share where I can get the colors and themes?

gino-m commented 3 weeks ago

I'd say this is a P2 for GA, relative to other tasks in the queue.

@rawbzz Would it be possible to provide a version of the designs and/or color scheme for "dark mode"?