Per-survey data sharing agreement in create/edit survey

[jcqli]

Adding agreement information in the create / edit survey flow

Have some multiple choice options or enabling custom text for survey creators to inform collectors of agreement

[gino-m]

Detailed FR:

• When creating a survey, survey organizers must select one of the following data sharing agreement options which must be accepted by data collectors before they begin collecting data:
  • Private: Data will be shared with survey organizers only.
  • Public: Survey organizers may share and use data publicly with no constraints (perhaps under CC0 license)
  • Custom agreement: The survey organizer will provide text which the data collector must accept before collecting data.
• The terms cannot be changed once the survey is shared.

@vittorino @rawbzz @amegantz for your attention.

[gino-m]

@vittorino Could you please paste the designs for changes to create/edit survey flow to allow the organizer to select or specify the data sharing agreement? See latest comment in Figma thread with @rawbzz for details.

[rawbzz]

Here's the screenshot for android FYI, copy is still WIP

[amegantz]

PTAL

[gino-m]

@amegantz @vittorino This looks great!!! Perhaps it would be helpful to show the survey organizers the exact text the data collectors will see, along with an explanation that that's what they're looking at?

[vittorino]

Do you think it's still unclear that the text is what they will see? If so, I would recommend explaining in the instructions rather than simulating a preview because it would be weird if we don't show the same for all 3 options. In my opinion we would be making the UI more complex than what it needs to be.

[vittorino]

FYI, small change in the dialog (no horizontal margins) to match the design for mobile:

[amegantz]

Do you think it's still unclear that the text is what they will see? If so, I would recommend explaining in the instructions rather than simulating a preview because it would be weird if we don't show the same for all 3 options. In my opinion we would be making the UI more complex than what it needs to be.

Like this?

[gino-m]

@nwkotto Would you like to take this one on?

[nwkotto]

Just for reference, this should be a helpful PR to base this off of: https://github.com/google/ground-platform/pull/1190

[nwkotto]

Updating the survey proto:

• Add enum for data sharing agreement types
• Include data sharing agreement enum value and custom agreement text values in survey proto

Creating the data-agreement component:

• Create form with data agreement type and custom agreement text fields
• Wire up the template, with mat-cards and mat-radio-buttons, to the component TS file
• Add form level validation to check that if custom is selected, custom text has been entered
• Create output to propagate validation to parent component
• Create input to pass down default type and custom text

Integrating component into create-survey:

• Create dataSharingAgreementToDocument function in proto-model-converter file
• Add new updateDataSharingAgreement method to data-store service
• Add DEFINE_DATA_SHARING_AGREEMENT value to SetupPhase enum
• Integrate new SetupPhase enum into getSetupPhase, setupPhaseToTitle, back, continue, updating the data sharing agreement on save

[nwkotto]

Forgot to tag this, but this PR is the next step for this issue: https://github.com/google/ground-platform/pull/1959

[jcqli]

This is currently displayed during the onboarding flow, need to add selected option in the survey settings

[gino-m]

[jcqli]

Is this closed with https://github.com/google/ground-platform/pull/1984 now? @nwkotto