google / gsocguides

Google Summer of Code Mentor and Student Guides
https://google.github.io/gsocguides/
Other
399 stars 154 forks source link

header logo issue #59

Closed fiorellarc05 closed 3 years ago

fiorellarc05 commented 3 years ago

to solve the header logo issue, I made a new image that can help

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

fiorellarc05 commented 3 years ago

@googlebot I signed it!

rspier commented 3 years ago

What's wrong with the existing logo?

fiorellarc05 commented 3 years ago

There's an open issue with the logo, I thought maybe you still need help with that

rspier commented 3 years ago

Got it, thanks.

Thank you for sending the PR, but.

I'm going to reject this PR because it doesn't just make the logo slightly bigger, but also changes the logo to something different. It's also a huge image, from 4k to 263k.

Increasing the size of the current image isn't just about making the image bigger, but the CSS needs tweaking too.