google / gson

A Java serialization/deserialization library to convert Java Objects into JSON and back
Apache License 2.0
23.23k stars 4.27k forks source link

Update GraphAdapterBuilderTest.java #2583

Closed onderyentar21 closed 8 months ago

onderyentar21 commented 8 months ago

Purpose

Description

Checklist

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Marcono1234 commented 8 months ago

Could you please explain this change a bit in detail? Currently it only adds a large comment but does not change the code in any way.

To me the current test code looks reasonable; it wants to verify that a list which contains itself is properly serialized by the graph adapter.

eamonnmcmanus commented 8 months ago

Closing for lack of response to the earlier question. Feel free to reopen if there is an answer to that question.