Closed 33nya closed 4 months ago
@Marcono1234 Thank you for your suggestion! It is very clear and helpful. I adjusted the content of the documentation. Please let me know if there is anything that needs to be improved.
Sorry for causing this stalemate situation. @33nya, the only open thing is really minor https://github.com/google/gson/pull/2647#discussion_r1532884565 about the missing space. Unfortunately GitHub does not let me mark my other review comments as resolved.
@eamonnmcmanus, or do you want to merge the changes anyway regardless of that change? If necessary it can also be done as part of another documentation related pull request.
@eamonnmcmanus, or do you want to merge the changes anyway regardless of that change? If necessary it can also be done as part of another documentation related pull request.
OK, I'll merge as-is, and if you or the original author want you can send a follow-up PR.
@Marcono1234 Sorry for causing any inconvenience. I misunderstood and wasn't sure if I could modify the PR after it had been approved, so I didn't make any changes. If it's convenient, could you assist with the adjustments in your current documentation PR? Otherwise, I will make the changes when I modify another documentation PR. Thank you!
@33nya, no problem. I have included that small change in #2654 now, but not sure if / when that will be merged. If you are planning to make some other (documentation) changes anyway, feel free to include it there as well. If not, then it is also not a problem I think; it is probably not worth it to have a separate pull request just for this small change.
@Marcono1234 Alright, I understand. Thank you for your assistance!
Purpose
Closes #1972.
JsonParser
specifications to demonstrate the usage of the three parse functions.Description
parseString(String json)
,parseReader(Reader reader)
, andparseReader(JsonReader reader)
functions inJsonParser
class.Checklist
mvn verify
, but can also be checked on its own usingmvn spotless:check
.\ Style violations can be fixed usingmvn spotless:apply
; this can be done in a separate commit to verify that it did not cause undesired changes.null
@since $next-version$
(
$next-version$
is a special placeholder which is automatically replaced during release)TestCase
)mvn clean verify javadoc:jar
passes without errors