search

google / gson

A Java serialization/deserialization library to convert Java Objects into JSON and back
Apache License 2.0
23.13k stars 4.27k forks source link

Fix API compatibility workflow failing when building previous version #2694

Closed Marcono1234 closed 1 month ago

Marcono1234 commented 1 month ago

Purpose

Fixes the current API compatibility workflows failures

Description

The workflow is currently failing for the jpms-test module:

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project jpms-test: Fatal error compiling: error: bad value for --module-version option: 'JAPICMP-OLD'

Therefore this pull request changes the dummy version number format, so that it is not rejected anymore.

eamonnmcmanus commented 1 month ago

Thanks!

It seems like the API compatibility workflow is not failing with this PR. Not sure if you want to update the description.

Marcono1234 commented 1 month ago

Oh you are right; I forgot to consider that since this changes the workflow, it applies directly (and not delayed only on the next pull request).