search

google / gtm-oauth2

Google Toolbox for Mac - OAuth 2 Controllers
Apache License 2.0
126 stars 70 forks source link

Add a podspec for GTMOAuth2. #54

Closed perotinus closed 8 years ago

perotinus commented 8 years ago

This depends on a not-yet-created podspec for GTMSessionFetcher, which will block using this (and testing it).

Also note that the tagging in the repository prevents this podspec from automatically mapping to a tagged version. This could be changed in the future.

Continuation and slight rework of #41.

thomasvl commented 8 years ago

Should I just nuke the 1.1 release and recreate it after this lands?

Also, should we tag the version like protobuf diff: https://github.com/google/protobuf/blob/master/Protobuf.podspec#L15

perotinus commented 8 years ago

Nuking 1.1 SGTM, assuming no-one is depending on it. I'll update the podspec.

I like the protobuf version tagging scheme, and like consistency across our projects. Do we want to do the same thing for GTM?

thomasvl commented 8 years ago

Naming - sure.

perotinus commented 8 years ago

OK, done there too. That will mean that, starting with 2.0.0, the scheme will change from google-toolbox-for-mac-x.y.z to vx.y.z, which seems reasonable to me.

thomasvl commented 8 years ago

Were you gonna send in the SessionFetcher spec so this one works?

Please squash these two commits into a single one so we get one thing landing to add the podspec.

perotinus commented 8 years ago

Divam is working on a GTMSessionFetcher podspec. He has it working, but he's been tied up with other work and wants to convert it to Ruby before making a PR.

I'll squash the commits, though, so this is ready when that one is.