Use bundleForClass instead of mainBundle

google / gtm-oauth2

Google Toolbox for Mac - OAuth 2 Controllers

Apache License 2.0

126 stars 70 forks source link

Use bundleForClass instead of mainBundle #64

Closed erickoledadevrel closed 8 years ago

erickoledadevrel commented 8 years ago

Required for compatibility with frameworks. Fixes #63.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented 8 years ago

CLAs look good, thanks!

thomasvl commented 8 years ago

fyi - I'm trying to figure out what to do here. Your change is right for folks using CocoaPods, but if someone was building from Source, it could break them (depending on how they added things to their project).

erickoledadevrel commented 8 years ago

It seems like the only case that would break would be one where the developer places the source code in a bundle other than mainBundle, but places the xib in mainBundle. How likely is that?

chrisballinger commented 8 years ago

This PR would be helpful for me. I currently have to manually copy the xib to my main bundle.

thomasvl commented 8 years ago

Yea, I've seem some very odd setups in the past via help request, but this is the right thing, so we'll deal with any fall out.

erickoledadevrel commented 8 years ago

Will a new version of the Pod need to be cut for this to roll out via Cocoapods?

thomasvl commented 8 years ago

Yup, trying to get to it today, otherwise tomorrow

thomasvl commented 8 years ago

Updated pod pushed.