search

google / gtm-oauth2

Google Toolbox for Mac - OAuth 2 Controllers
Apache License 2.0
126 stars 70 forks source link

Sign-up/sign-in ios UiWebView is not zoomable #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
0. Start with an iOS application where you are not yet signed in to Google
1. Go through an application flow for iOS that requires sign-in
2. Touch the "sign up" button to create a new account
3. Watch the behavior of the UIWebView as it redirects you to an account 
sign-up page

What is the expected output? What do you see instead?

The sign-in page is presentationally optimized for mobile: 
https://accounts.google.com/ServiceLogin?[queryparameters]. The sign-up page 
that the UIWebView directs to from there when the user clicks -- 
https://accounts.google.com/SignUpGadget?[queryparameters] is not mobile 
optimized.

Moreover, the UIWebView is not set to allow the content to be zoomable! Even if 
SignUpGadget is not presenting mobile-optimized HTML -- this is likely beyond 
the scope of this codebase -- the UIWebView should assume it may have to zoom 
or unzoom its content. The server can override this on pages where it knows 
better by including <meta name="viewport" content="user-scalable=no"> in the 
content -- as indeed is done for ServiceLogin -- but the client's baseline 
assumption should be different.

What version of the product are you using? On what operating system?

7-Oct-2011 release of gtm-oauth2. Running on the XCode 4.2 iOS 5.0 simulator 
(bug originally reported on real hardware, though.)

Please provide any additional information below.

Original issue reported on code.google.com by hil...@google.com on 15 Feb 2012 at 5:42

GoogleCodeExporter commented 9 years ago 
The user's first view of SignUpGadget, for completeness, is zoomed in and is 
mostly of a large GMail logo. The view is pannable, but usability is low.

Original comment by hil...@google.com on 15 Feb 2012 at 5:54

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Proposed fix attached. Really all it consists of is checking the "Scales Page 
to Fit" checkbox in the interface builder for the relevant UIWebView in the 
relevant .xib.

Original comment by hil...@google.com on 15 Feb 2012 at 9:09

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by grobb...@google.com on 18 Feb 2012 at 2:54