search

google / gtm-oauth2

Google Toolbox for Mac - OAuth 2 Controllers
Apache License 2.0
125 stars 70 forks source link

Update GTMOAuth2Authentication.m #99

Closed zkrige closed 6 years ago

zkrige commented 6 years ago

fix for XCode 9 static analysis warning:

GTMOAuth2Authentication.m:1123:7: Converting a pointer value of type 'NSNumber *' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue

thomasvl commented 6 years ago

fyi - Remember gtm-oauth2 is deprecated

thomasvl commented 6 years ago

Thanks for the patch!

zkrige commented 6 years ago

Interesting - thanks for the heads up. I'm using the GoogleSignIn POD which has a dependency on gtm-oauth2. So the dependency is coming from a google pod

thomasvl commented 6 years ago

Interesting - thanks for the heads up. I'm using the GoogleSignIn POD which has a dependency on gtm-oauth2. So the dependency is coming from a google pod

I've been talking to them about removing the dep, they don't actually use the code, so eventually the dep will go away.

zkrige commented 6 years ago

cool. Well in the mean time, its one less warning to worry about :)