google / gts

☂️ TypeScript style guide, formatter, and linter.
https://github.com/google/gts
Apache License 2.0
5.05k stars 205 forks source link

gts indent doesn't match Google style #626

Open gcc42 opened 3 years ago

gcc42 commented 3 years ago

Specifically when breaking lines. Google style has good line break rules that prettier's indent rules conflicts with. Given that gts enforces prettier/prettier, my fix gives me breaks like this:

new Error('This is a long string that we'll need to break. Google style'
    + 'recommends continuing at at least +4 spaces, while prettier enforces +2');

Here's the corresponding rule: https://google.github.io/styleguide/jsguide.html#formatting-indent

bcoe commented 2 years ago

@gcc42 I agree, we should make an effort to fix this.