google / gts

☂️ TypeScript style guide, formatter, and linter.
https://github.com/google/gts
Apache License 2.0
5.08k stars 206 forks source link

feat: move to eslint-plugin-n #765

Closed aladdin-add closed 7 months ago

aladdin-add commented 1 year ago

eslint-plugin-n is a community-maintained fork of eslint-plugin-node: https://github.com/eslint-community/eslint-plugin-n

It ensures that an important module like eslint-plugin-node is kept up to date, with both ESLint 8.x and with Node.js itself.

Similar PR: electron/electron#38874

Full disclosure: I'm part of the ESLint Community Core Team.

aladdin-add commented 1 year ago

~looks like the package still supports node.js v12, while eslint-plugin-n has dropped node.js < 16 (EOL). You can merge the PR after dropping node.js < 16. :)~

~refs: https://github.com/nodejs/release#end-of-life-releases~


no worries, I've reverted it to eslint-plugin-n v15.

tonycoco commented 7 months ago

Going to track changes here: #865 with tests fixed and passing