feat!: Set `no-floating-promises` to `error`

google / gts

☂️ TypeScript style guide, formatter, and linter.

https://github.com/google/gts

Apache License 2.0

5.04k stars 203 forks source link

feat!: Set `no-floating-promises` to `error` #793

Open danielbankhead opened 12 months ago

danielbankhead commented 12 months ago

Un-revert https://github.com/google/gts/pull/808 and set no-floating-promises to error

Context:

https://github.com/google/gts/pull/756#issuecomment-1714363976

Dependency:

https://github.com/googleapis/synthtool/pull/1877

naseemkullah commented 7 months ago

hey @danielbankhead can we move forward with this now? I can make a PR if so, thank you!

danielbankhead commented 7 months ago

@naseemkullah feel free to create a PR, however it will take some time before we do another major release

tonycoco commented 5 months ago

Working on another major release with some changes to drop Node 14/16 soon. Anyone want to create a PR I can help merge.

danielbankhead commented 5 months ago

@tonycoco We cannot drop Node 14/16 without a proposal to update all googleapis Node.js client libraries. We're planning to get to this sometime this semester.