search

google / guava

Google core libraries for Java
Apache License 2.0
49.98k stars 10.85k forks source link

Delete local copies of LongAdder/Striped64 in favor of java.util.concurrent.atomic.LongAdder #3183

Open mjd507 opened 6 years ago

mjd507 commented 6 years ago

in the package com.google.common.hash and com.google.common.cache, some files like LongAddable, LongAddables, LongAdder, and Striped64 are the same.

kluever commented 6 years ago

Yep, we don't want them to be public APIs, so the only way to use them in both packages is to make 2 copies.

What I didn't realize is that LongAdder actually made its way into Java8. I suspect we can delete our copies of Striped64 and LongAdder in our Java8 branch. @lowasser ?

lowasser commented 6 years ago

I think this would break GWT/J2CL.