search

google / guava

Google core libraries for Java
Apache License 2.0
50.1k stars 10.87k forks source link

ImmutableSortedMap should implement NavigableMap #664

Closed gissuebot closed 9 years ago

gissuebot commented 9 years ago

Original issue created by cow...@bbs.darktech.org on 2011-07-18 at 08:34 PM

I understand that Guava doesn't support NavigableMap because of the requirement to retain Java5 backwards-compatiblity, but now that JDK7 is due out in 10 days I am hoping you will revisit the matter.

Either way, please keep this issue open for the purpose of collecting votes.

gissuebot commented 9 years ago

Original comment posted by kevinb@google.com on 2011-07-19 at 12:18 AM

No point in collecting votes on this issue; you want issue 32.

Labels: Type-Enhancement Blocked On: #32

gissuebot commented 9 years ago

Original comment posted by fry@google.com on 2011-07-28 at 05:23 PM

(No comment entered for this change.)

Status: Accepted

gissuebot commented 9 years ago

Original comment posted by wasserman.louis on 2011-10-16 at 11:38 PM

That said, it already does implement the NavigableMap methods internally, but it a) doesn't expose them and b) doesn't implement the NavigableMap interface. If we exposed these, would that satisfy your needs?

gissuebot commented 9 years ago

Original comment posted by cow...@bbs.darktech.org on 2011-10-17 at 01:56 AM

Exposing the methods would help, but I'd like to keep this issue open until the class implements the NavigableMap interface.

gissuebot commented 9 years ago

Original comment posted by wasserman.louis on 2011-10-17 at 01:58 AM

Agreed, clearly. I'm just not at all sure what kind of timeline we should expect for JDK 6.

gissuebot commented 9 years ago

Original comment posted by fry@google.com on 2011-12-10 at 04:12 PM

(No comment entered for this change.)

Labels: Package-Collect

gissuebot commented 9 years ago

Original comment posted by wasserman.louis on 2012-03-17 at 07:42 PM

I understand that Chris is working on this for release 12, but I'm not positive -- Chris?

Labels: Milestone-Release12 CC: cpovirk@google.com

gissuebot commented 9 years ago

Original comment posted by cpovirk@google.com on 2012-03-17 at 08:11 PM

Correct. I got an LGTM for "my" (really Louis's) CL for "ImmutableSortedSet implements NavigableSet," so I'll be submitting it on Monday. After that, I don't anticipate any major problems with his ImmutableSortedMap CL.

gissuebot commented 9 years ago

Original comment posted by cpovirk@google.com on 2012-03-28 at 07:41 PM

Submitted internally. Will be mirrored out soon.

Status: Fixed