search

google / guetzli

Perceptual JPEG encoder
Apache License 2.0
12.92k stars 976 forks source link

No issue, but question: is is production ready? #133

Open rogierlommers opened 7 years ago

rogierlommers commented 7 years ago

We have done some experimenting with Guetzli and we are very happy with the results. A big reduction in image sizes; thanks for this! However now I have a question: it Guetzli production ready? Can we use the latest release, add it to our containers and use the binary on production? Or is it too early?

karamanolev commented 7 years ago

We deployed this on a site with ~18000 public-facing images of which we host a full-sized version and a thumbnailed version about 10 days ago. The conversion finished in about 2 days. So far, everything has been great. No errors while encoding, no serious artifacts that we've noticed.

robryk commented 7 years ago

Security-wise, we have devoted so far something on the order of tens of CPU hours for fuzzing and we will have it fuzzed on oss-fuzz soon (google/oss-fuzz#480). However, Guetzli is a JPEG file parser, so I'd suggest a high level of caution if you run it on untrusted images. I strongly recommend sandboxing it (e.g. using seccomp).

Usability-wise, there are valid JPEGs which Guetzli is unable to parse (e.g. any downsampling other than 4:4:4 or 4:2:0). It will fail to recompress such JPEGs (return a nonzero exit code); however, it will happily compress those images if provided as PNGs.