search

google / guice

Guice (pronounced 'juice') is a lightweight dependency injection framework for Java 11 and above, brought to you by Google.
https://github.com/google/guice
Apache License 2.0
12.51k stars 1.67k forks source link

Optimize memory allocation in InternalContext by lazy initialization #1805

Closed Malaydewangan09 closed 8 months ago

Malaydewangan09 commented 8 months ago

perf(InternalContext): Optimize memory allocation by lazy initializing constructionContexts

The current implementation of InternalContext eagerly initializes the constructionContexts map, leading to unnecessary memory allocation when retrieving singleton instances via Injector#getInstance(...) or Provider#get(). This commit lazily initializes the constructionContexts map in the getConstructionContext method, avoiding the creation of the IdentityHashMap and associated Object array when not needed.

This optimization should significantly reduce memory overhead in scenarios where singleton instances are accessed frequently, improving the overall memory footprint of applications using Guice.

Resolves: #1802

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.