Support task creation options passed by ContainerD 1.2.4

google / gvisor-containerd-shim

containerd shim for gVisor

https://gvisor.dev

Apache License 2.0

79 stars 30 forks source link

Support task creation options passed by ContainerD 1.2.4 #20

Closed jmillikin-stripe closed 5 years ago

jmillikin-stripe commented 5 years ago

When ContainerD v1.2.4 creates a task, it may pass a *runctypes.CreateOptions in the request options field. This currently causes the gvisor-containerd-shim to reject the request.

This PR allows the shim to handle requests with creation options set, and also slightly improves the error message so future failures of this kind are easier to localize to the shim.

Fixes https://github.com/google/gvisor-containerd-shim/issues/19

Random-Liu commented 5 years ago

/lgtm

Please note that we mainly tested gvisor-containerd-shim with Kubernetes + CRI + containerd.

By using containerd directly with gvisor-containerd-shim, there might be things broken, and might be things not supported. Feel free to open a bug if you encountered any issue.