google / gvisor-containerd-shim

containerd shim for gVisor
https://gvisor.dev
Apache License 2.0
79 stars 30 forks source link

fix: instructions to install shim #21

Closed zhuangqh closed 5 years ago

zhuangqh commented 5 years ago
  1. original LATEST_RELEASE is about containerd-shim-runsc-v1, we should choose the second line gvisor-containerd-shim. lol

  2. should use /etc/containerd/gvisor-containerd-shim.toml not yaml : )

    fixes #18

Signed-off-by: zhuangqh zhuangqhc@gmail.com

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

zhuangqh commented 5 years ago

I signed it!

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ianlewis commented 5 years ago

Also, please note that this fixes #18