search

google / gvisor-containerd-shim

containerd shim for gVisor
https://gvisor.dev
Apache License 2.0
79 stars 30 forks source link

Use context.Background for runtime.Wait. #28

Closed Random-Liu closed 5 years ago

Random-Liu commented 5 years ago

After upgrading ttrpc in https://github.com/google/gvisor-containerd-shim/pull/27, it now supports context timeout.

For operation like runtime.Wait that we expect it to run forever, we should not scope it with the request context. Use context.Background() instead.

Signed-off-by: Lantao Liu lantaol@google.com

Random-Liu commented 5 years ago

This is causing test failure for Kubernetes + gvisor.

Random-Liu commented 5 years ago

Hm, it seems that we only have 2 code owners today https://github.com/google/gvisor-containerd-shim/blob/master/CODEOWNERS

@ianlewis Can we add @fvoznika as a code owner?