search

google / gvisor-containerd-shim

containerd shim for gVisor
https://gvisor.dev
Apache License 2.0
79 stars 30 forks source link

Reduce `runsc state` call. #39

Open Random-Liu opened 4 years ago

Random-Liu commented 4 years ago

We may want similar optimization with https://github.com/containerd/containerd/pull/3711.

Or leverage https://github.com/google/gvisor/issues/238

ianlewis commented 4 years ago

If the caching is done in containerd via containerd/containerd#3711 do we need to make any changes to the shim? Or is it just a matter if updating our dependencies?

Random-Liu commented 4 years ago

Yeah, we still need it, because we have corresponding code on our side https://github.com/google/gvisor-containerd-shim/tree/master/pkg/v1/proc

On Wed, Oct 9, 2019 at 9:24 PM Ian Lewis notifications@github.com wrote:

If the caching is done in containerd via containerd/containerd#3711 https://github.com/containerd/containerd/pull/3711 do we need to make any changes to the shim? Or is it just a matter if updating our dependencies?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/gvisor-containerd-shim/issues/39?email_source=notifications&email_token=ABMNLO45SICDBLI6NAASYUDQN2U6PA5CNFSM4I5WEKJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA2Q2EY#issuecomment-540347667, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMNLO4S4EKIMG7HE5SYYATQN2U6PANCNFSM4I5WEKJQ .

ianlewis commented 4 years ago

I think caching the state is ok for now. Implementing a urpc interface to the sandbox is a bit more involved.