google / gvisor-containerd-shim

containerd shim for gVisor
https://gvisor.dev
Apache License 2.0
79 stars 30 forks source link

Update to containerd 1.3.4 #55

Closed ianlewis closed 4 years ago

ianlewis commented 4 years ago

I can't reproduce the issues with the test failures myself on an ubuntu VM. Something about the travis environments is causing e2e tests to fail.

ianlewis commented 4 years ago

It seems shims built with containerd 1.3 expect a TTRPC_ADDRESS environment variable to be set for event publishing, which containerd 1.2 doesn't set. Looks like shims built with containerd 1.3 won't be compatible with containerd 1.2. At least for the time being.

https://github.com/containerd/containerd/blob/release/1.3/runtime/v2/shim/shim.go#L172

ianlewis commented 4 years ago

Closing this since we can't support containerd 1.2 if we upgrade to containerd 1.3 packages in the shim.