search

google / gvisor

Application Kernel for Containers
https://gvisor.dev
Apache License 2.0
15.57k stars 1.28k forks source link

Clean up netstack APIs with PacketBuffer #3574

Open kevinGC opened 4 years ago

kevinGC commented 4 years ago

As we move from passing VectorisedView to PacketBuffer, more state is living in the PacketBuffer. Values that are passed explicitly (e.g. protocol numbers, addresses) should be fields or methods of PacketBuffer.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 3 years ago

There are TODOs still referencing this issue:

  1. pkg/tcpip/stack/packet_buffer.go:86: Remove the separately passed protocol

Search TODO

github-actions[bot] commented 1 year ago

A friendly reminder that this issue had no activity for 120 days.

github-actions[bot] commented 9 months ago

This issue has been closed due to lack of activity.

github-actions[bot] commented 9 months ago

There are TODOs still referencing this issue:

  1. pkg/tcpip/stack/packet_buffer.go:123: Remove the separately passed protocol

Search TODO

github-actions[bot] commented 5 months ago

A friendly reminder that this issue had no activity for 120 days.